Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45839/ --- (Updated April 6, 2016, 11:08 p.m.) Review request for mesos, Joerg Schad,

Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Michael Park
> On April 6, 2016, 10:21 p.m., Kevin Klues wrote: > > Ship It! > > Kevin Klues wrote: > My only comment would be to add a comment about what this line is doing. > It's not obvious that this is the delimiter used in verbose mode. Oh, good point! Thanks, will do. - Michael

Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Kevin Klues
> On April 6, 2016, 10:21 p.m., Kevin Klues wrote: > > Ship It! My only comment would be to add a comment about what this line is doing. It's not obvious that this is the delimiter used in verbose mode. - Kevin --- This is an

Re: Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45839/#review127476 --- Ship it! Ship It! - Kevin Klues On April 6, 2016, 9:46

Review Request 45839: Fixed commit message hook to not lint the diff in verbose mode.

2016-04-06 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45839/ --- Review request for mesos, Joerg Schad, Kevin Klues, and Vinod Kone. Bugs: