Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-07-13 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/#review142099 --- Ship it! Note: I replaced `NULL` with `nullptr` prior to

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-06-02 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/ --- (Updated June 2, 2016, 8:30 p.m.) Review request for mesos and Joris Van

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-04-11 Thread Neil Conway
> On April 11, 2016, 4:06 a.m., Kevin Klues wrote: > > 3rdparty/libprocess/src/process.cpp, lines 2170-2195 > > > > > > Is there a reason, we can't just remove the gc process from the list as > > a preliminary

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-04-11 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/#review128085 --- Patch looks great! Reviews applied: [45991, 45995, 45996, 45999]

Re: Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-04-10 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/#review128061 --- 3rdparty/libprocess/src/process.cpp (lines 2167 - 2188)

Review Request 45999: Ensure GC is terminated last during libprocess shutdown.

2016-04-10 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45999/ --- Review request for mesos and Joris Van Remoortere. Bugs: MESOS-5144