Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/ --- (Updated April 15, 2016, 6:07 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/#review129051 --- Fix it, then Ship it! src/master/http.cpp (lines 437 - 439)

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

> On April 14, 2016, 5:10 p.m., Greg Mann wrote: > > src/master/validation.hpp, line 47 > > > > > > Do we really want to have a default value for an argument to a > > validation function? It makes me a bit uneasy; if

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/ --- (Updated April 14, 2016, 5:46 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/#review128914 --- Looks good! A couple small things below. src/master/http.cpp (li

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/ --- (Updated April 14, 2016, 3:35 p.m.) Review request for mesos, Greg Mann and Vin

Re: Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/#review128731 --- src/master/master.cpp (line 850)

Review Request 46115: Added AuthN for HTTP based frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46115/ --- Review request for mesos, Greg Mann and Vinod Kone. Bugs: MESOS-3923 https: