Re: Review Request 46319: Added authorization to agents' `/statistics` endpoints.

2016-04-22 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review130057 --- Looks great! Just some minor points, and then we need to settle

Re: Review Request 46319: Added authorization to agents' `/statistics` endpoints.

2016-04-19 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review129506 --- Ship it! The test case may need to be moved into

Re: Review Request 46319: Added authorization to agents' `/statistics` endpoints.

2016-04-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review129373 --- Patch looks great! Reviews applied: [45922, 46203, 46318, 46319]

Re: Review Request 46319: Added authorization to agents' `/statistics` endpoints.

2016-04-18 Thread Benjamin Bannier
> On April 18, 2016, 3:28 p.m., Jan Schlicht wrote: > > src/slave/http.cpp, lines 613-616 > > > > > > You don't need to do that. If authorization is disabled, > > `authorizedEndpoint` will always return `true`.

Re: Review Request 46319: Added authorization to agents' `/statistics` endpoints.

2016-04-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- (Updated April 18, 2016, 3:42 p.m.) Review request for mesos, Adam B,

Re: Review Request 46319: Added authorization to agents' `/statistics` endpoints.

2016-04-18 Thread Jan Schlicht
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/#review129327 --- src/slave/http.cpp (lines 613 - 616)

Review Request 46319: Added authorization to agents' `/statistics` endpoints.

2016-04-18 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46319/ --- Review request for mesos, Adam B, Alexander Rojas, and Jan Schlicht. Bugs: