Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-05-10 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated May 10, 2016, 1:28 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-05-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated May 5, 2016, 3:38 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated April 22, 2016, 2:38 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-21 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/#review129936 --- Fix it, then Ship it! src/slave/slave.cpp (lines 2041 - 2042)

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated April 21, 2016, 2:28 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated April 21, 2016, 2:06 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-19 Thread Alexander Rukletsov
> On April 19, 2016, 1:09 a.m., Ben Mahler wrote: > > src/internal/evolve.hpp, line 46 > > > > > > Why did you choose to inject it here? Seems better closer to TaskInfo? Because in "mesos.proto" `KillPolicy` is

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-18 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/#review129457 --- Looks good, but held off on a ship it because there is a bug in

Re: Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- (Updated April 18, 2016, 12:44 p.m.) Review request for mesos and Ben Mahler.

Review Request 46323: Propagated KillPolicy in kill task from scheduler to executor.

2016-04-18 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46323/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-4908