Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

2016-05-05 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated May 5, 2016, 3:37 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

2016-04-22 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated April 22, 2016, 2:36 p.m.) Review request for mesos, Benjamin Bannier

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

2016-04-22 Thread Alexander Rukletsov
> On April 21, 2016, 4:44 p.m., Benjamin Bannier wrote: > > src/launcher/executor.cpp, lines 90-93 > > > > > > Now that we add a fourth state documenting e.g., which states are > > initial or terminal might help

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

2016-04-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review129902 --- Fix it, then Ship it! src/launcher/executor.cpp (lines 90 -

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

2016-04-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/#review129903 --- Patch looks great! Reviews applied: [46321, 46322, 46323, 46325,

Re: Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

2016-04-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- (Updated April 21, 2016, 2:28 p.m.) Review request for mesos, Benjamin Bannier

Review Request 46491: Ensured escalated() is not called after reaped() in command executor.

2016-04-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46491/ --- Review request for mesos, Benjamin Bannier and Ben Mahler. Bugs: MESOS-5240