Re: Review Request 46875: Some cleanup in weights_handler.cpp.

2016-06-18 Thread Guangya Liu
> On 六月 17, 2016, 1 p.m., Alexander Rukletsov wrote: > > I beleive `request.body` is supposed to be the contents, and not the file, > > right? Just FYI, Alex, I have fixed this issue in https://reviews.apache.org/r/48680/ and it was merged today. - Guangya

Re: Review Request 46875: Some cleanup in weights_handler.cpp.

2016-06-17 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46875/#review138309 --- Ship it! Ship It! - Adam B On April 30, 2016, 11:52 p.m.,

Re: Review Request 46875: Some cleanup in weights_handler.cpp.

2016-06-17 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46875/#review138209 --- I beleive `request.body` is supposed to be the contents, and not

Re: Review Request 46875: Some cleanup in weights_handler.cpp.

2016-05-01 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46875/#review131266 --- Patch looks great! Reviews applied: [46875] Passed command:

Review Request 46875: Some cleanup in weights_handler.cpp.

2016-05-01 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/46875/ --- Review request for mesos, Adam B and Alexander Rukletsov. Repository: mesos