Re: Review Request 47374: Separated mesos test helpers into a separate library.

2016-06-15 Thread Till Toenshoff
> On June 14, 2016, 12:26 a.m., Till Toenshoff wrote: > > Overall, I am not convinced this is reaching the goals we have just yet... > > > > Let me try to specify our goals; > > (a) we want to enable mesos-modules (tests) to reuse our test helpers/utils > > - things like `cluster.cpp` etc. > >

Re: Review Request 47374: Separated mesos test helpers into a separate library.

2016-06-13 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review137245 --- Overall, I am not convinced this is reaching the goals we have jus

Re: Review Request 47374: Separated mesos test helpers into a separate library.

2016-06-13 Thread Till Toenshoff
> On June 12, 2016, 9:52 a.m., Kapil Arya wrote: > > src/Makefile.am, lines 1950-1951 > > > > > > I don't think we should be embedding absolute paths to source/build > > directories in a library that we are plannin

Re: Review Request 47374: Separated mesos test helpers into a separate library.

2016-06-12 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/#review137162 --- src/Makefile.am (lines 1950 - 1951)

Re: Review Request 47374: Separated mesos test helpers into a separate library.

2016-06-11 Thread Adam B
> On May 23, 2016, 5:09 p.m., Adam B wrote: > > src/Makefile.am, lines 1937-1938 > > > > > > Why does libmesos_tests_la_SOURCES need to include qos_controllers code? > > Joseph Wu wrote: > I don't remember the

Re: Review Request 47374: Separated mesos test helpers into a separate library.

2016-06-10 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47374/ --- (Updated June 10, 2016, 5:03 p.m.) Review request for mesos, Adam B, Artem Haru