Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review135586 --- Fix it, then Ship it! src/slave/containerizer/fetcher.cpp

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-29 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/ --- (Updated May 29, 2016, 10:20 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-27 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/ --- (Updated May 28, 2016, 2:22 a.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-26 Thread Alex Clemmer
> On May 24, 2016, 11:22 p.m., Joris Van Remoortere wrote: > > src/slave/containerizer/fetcher.cpp, lines 210-211 > > > > > > Why is this logic compiled out on windows? > > Does it not apply? If so, can we add a

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-26 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/ --- (Updated May 26, 2016, 2:23 p.m.) Review request for mesos, Daniel Pravat,

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-24 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review134659 --- Fix it, then Ship it! src/slave/containerizer/fetcher.cpp

Re: Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-17 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/#review133618 --- Bad patch! Reviews applied: [47472, 47471, 47470, 47469, 47468,

Review Request 47472: Windows: Added support for `fetcher.cpp`.

2016-05-17 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47472/ --- Review request for mesos, Daniel Pravat, Artem Harutyunyan, Joris Van