Re: Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

2016-05-23 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47706/#review134415 --- Ship it! Ship It! - Benjamin Mahler On May 23, 2016, 7:06

Re: Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

2016-05-23 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47706/ --- (Updated May 23, 2016, 7:06 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

2016-05-23 Thread Kevin Klues
> On May 23, 2016, 6:12 a.m., Guangya Liu wrote: > > src/slave/containerizer/mesos/isolator.hpp, lines 122-123 > > > > > > I think it is better to keep those two lines as comments for `status()` I would normally

Re: Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

2016-05-23 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47706/#review134308 --- src/slave/containerizer/mesos/isolator.hpp

Review Request 47706: Provided defaults for all virtual functions in `mesos::slave::Isolator'.

2016-05-22 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47706/ --- Review request for mesos, Benjamin Mahler and Jie Yu. Bugs: MESOS-5435