Re: Review Request 47990: Added move semantics to `Pipe::write()`.

2016-05-31 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/#review135654 --- Fix it, then Ship it! 3rdparty/libprocess/src/http.cpp (line 4

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

2016-05-30 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/ --- (Updated May 30, 2016, 11:21 p.m.) Review request for mesos, Benjamin Mahler, M

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

2016-05-29 Thread Anand Mazumdar
> On May 29, 2016, 4:46 a.m., Vinod Kone wrote: > > what's the reason for not having a rvalue ref overload? I discussed this with mpark and we agreed that for sink arguments, just passing by value is good enough for movable types like `std::string`. This incurs the extra overhead of one move f

Re: Review Request 47990: Added move semantics to `Pipe::write()`.

2016-05-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/#review135416 --- what's the reason for not having a rvalue ref overload? - Vinod K

Review Request 47990: Added move semantics to `Pipe::write()`.

2016-05-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47990/ --- Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone. Reposi