Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

2016-05-31 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47991/#review135653 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp (lin

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

2016-05-29 Thread Anand Mazumdar
> On May 29, 2016, 4:53 a.m., Vinod Kone wrote: > > don't think i follow this change. can you explain why wrapping it in owned > > performs better? Copying the `Request` object upon every `::stream` call was very expensive. The motive behind this change is to create the `Request` object once a

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

2016-05-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47991/#review135417 --- don't think i follow this change. can you explain why wrapping it

Re: Review Request 47991: Passed `Request` object by ptr instead of copying it.

2016-05-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47991/#review135361 --- Patch looks great! Reviews applied: [47986, 47987, 47988, 47989,

Review Request 47991: Passed `Request` object by ptr instead of copying it.

2016-05-27 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47991/ --- Review request for mesos, Benjamin Mahler, Michael Park, and Vinod Kone. Reposi