Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

> On June 21, 2016, 9:45 p.m., Anand Mazumdar wrote: > > src/slave/http.cpp, line 620 > > > > > > hmm.. We forgot evolving the response here? My bad when rebasing this chain, post a follow patch at

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review138948 --- src/slave/http.cpp (line 620)

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review138064 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48799,

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

> On June 16, 2016, 10:03 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [48603, 48602, 48601, 48600, 48597, 48596, 48737, 48595, > > 48588, 48587, 48585, 48584, 48583] > > > > Failed command: ./support/apply-review.sh -n -r 48601 > > > > Error: > > 2016-06-16 10:03:55

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- (Updated June 16, 2016, 5:26 p.m.) Review request for mesos, Abhishek

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

> On June 16, 2016, 10:03 a.m., Mesos ReviewBot wrote: > > Bad patch! > > > > Reviews applied: [48603, 48602, 48601, 48600, 48597, 48596, 48737, 48595, > > 48588, 48587, 48585, 48584, 48583] > > > > Failed command: ./support/apply-review.sh -n -r 48601 > > > > Error: > > 2016-06-16 10:03:55

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review137950 --- Bad patch! Reviews applied: [48603, 48602, 48601, 48600, 48597,

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review137899 --- Ship it! Ship It! - Vinod Kone On June 15, 2016, 4:28 p.m.,

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- (Updated June 15, 2016, 4:28 p.m.) Review request for mesos, Abhishek

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- (Updated June 15, 2016, 2:51 p.m.) Review request for mesos, Abhishek

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- (Updated June 15, 2016, 2:31 p.m.) Review request for mesos, Abhishek

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review137608 --- same comments as previous review. - Vinod Kone On June 12,

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/#review137187 --- Patch looks great! Reviews applied: [48583, 48584, 48585, 48587,

Re: Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- (Updated June 12, 2016, 6:04 p.m.) Review request for mesos, Abhishek

Review Request 48603: Implemented v1::agent::Call::GET_METRICS.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48603/ --- Review request for mesos, Anand Mazumdar, zhou xing, Jay Guo, and Vinod Kone.