Re: Review Request 48911: Show orphan tasks in WebUI.

2016-06-25 Thread Tomasz Janiszewski
> On June 21, 2016, 9:39 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 151-154 > > > > > > This still looks incorrect, we need to set the stopped time only if the > > last state

Re: Review Request 48911: Show orphan tasks in WebUI.

2016-06-21 Thread Benjamin Mahler
> On June 21, 2016, 9:39 p.m., Benjamin Mahler wrote: > > src/webui/master/static/js/controllers.js, lines 151-154 > > > > > > This still looks incorrect, we need to set the stopped time only if the > > last state

Re: Review Request 48911: Show orphan tasks in WebUI.

2016-06-21 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/#review138946 --- Fix it, then Ship it! Looks good, thank you! Can you please

Re: Review Request 48911: Show orphan tasks in WebUI.

2016-06-18 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/#review138436 --- Ship it! Ship It! - haosdent huang On June 18, 2016, 8:22

Re: Review Request 48911: Show orphan tasks in WebUI.

2016-06-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/#review138431 --- Patch looks great! Reviews applied: [48911] Passed command:

Review Request 48911: Show orphan tasks in WebUI.

2016-06-18 Thread Tomasz Janiszewski
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48911/ --- Review request for mesos, Benjamin Mahler, haosdent huang, Ross Allen, and