Re: Review Request 49402: Added tests for IP based certificate validation.

2016-07-04 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49402/ --- (Updated July 4, 2016, 4:30 p.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49402: Added tests for IP based certificate validation.

2016-06-30 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49402/ --- (Updated July 1, 2016, 12:51 a.m.) Review request for mesos, Adam B, Albert

Re: Review Request 49402: Added tests for IP based certificate validation.

2016-06-30 Thread Till Toenshoff
> On June 30, 2016, 4:03 p.m., Joris Van Remoortere wrote: > > 3rdparty/libprocess/src/tests/ssl_tests.cpp, lines 781-783 > > > > > > Let's parameterize the existing tests these are copied from since the > >

Re: Review Request 49402: Added tests for IP based certificate validation.

2016-06-30 Thread Joris Van Remoortere
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49402/#review140177 --- Fix it, then Ship it!

Review Request 49402: Added tests for IP based certificate validation.

2016-06-29 Thread Till Toenshoff
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49402/ --- Review request for mesos, Adam B, Albert Strasheim, Artem Harutyunyan, Joris