Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-05 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140944 --- Fix it, then Ship it! Would fix these minor style nits while

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-05 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- (Updated July 6, 2016, 1:44 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-05 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140912 --- Fix it, then Ship it! src/master/http.cpp (line 2081)

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-03 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140586 --- Ship it! Looks like you fixed the issues. Not sure why you

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-02 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140492 --- Ship it! Ship It! - haosdent huang On July 1, 2016, 11:34

Re: Review Request 49488: Refactor Master::Http::getAgents into helper function.

2016-07-01 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- (Updated July 1, 2016, 11:34 p.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49488: Refactor master::Http::getAgents into helper function.

2016-07-01 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/#review140404 --- src/master/http.cpp (lines 1964 - 1967)

Re: Review Request 49488: Refactor master::Http::getAgents into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- (Updated July 1, 2016, 2:47 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 49488: Refactor master::Http::GetAgents into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- (Updated July 1, 2016, 2:47 a.m.) Review request for mesos, Anand Mazumdar,

Review Request 49488: Refactor master::Http::GetAgents into helper function.

2016-06-30 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49488/ --- Review request for mesos, Anand Mazumdar, haosdent huang, and Vinod Kone.