Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review142525 --- Patch looks great! Reviews applied: [49837, 49844] Passed

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/ --- (Updated July 17, 2016, 9:15 p.m.) Review request for mesos, Vinod Kone and

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review142187 --- Patch looks great! Reviews applied: [49837, 49844] Passed

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review142140 --- Fix it, then Ship it! src/master/master.hpp (line 1758)

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/ --- (Updated July 12, 2016, 1:25 a.m.) Review request for mesos, Vinod Kone and

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1765 > > > > > > don't follow why this has to be Owned. > > Anand Mazumdar wrote: > Same reasoning as above. If it's not an

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1765 > > > > > > don't follow why this has to be Owned. > > Anand Mazumdar wrote: > Same reasoning as above. If it's not an

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1765 > > > > > > don't follow why this has to be Owned. > > Anand Mazumdar wrote: > Same reasoning as above. If it's not an

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1765 > > > > > > don't follow why this has to be Owned. > > Anand Mazumdar wrote: > Same reasoning as above. If it's not an

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 7:21 p.m., Vinod Kone wrote: > > src/master/master.hpp, line 1754 > > > > > > should this be done in ~HttpConnection instead? hmm, `HttpConnection` is not meant to be used as an RAII object. We

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review141411 --- src/master/master.hpp (line 1754)

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review141398 --- Patch looks great! Reviews applied: [49837, 49844] Passed

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 4:22 a.m., Zhitao Li wrote: > > src/master/master.cpp, lines 7602-7610 > > > > > > Does the order of these two statements matter (e.g. we need ot ensure > > `subscribers.subscribed` always has

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

> On July 9, 2016, 4:22 a.m., Zhitao Li wrote: > > src/master/master.cpp, lines 7602-7610 > > > > > > Does the order of these two statements matter (e.g. we need ot ensure > > `subscribers.subscribed` always has

Re: Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/#review141387 --- src/master/master.cpp (lines 7598 - 7606)

Review Request 49844: Fixed a subscriber FD leak when running tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49844/ --- Review request for mesos, Vinod Kone and Zhitao Li. Bugs: MESOS-5812