Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-18 Thread Guangya Liu
> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-18 Thread Guangya Liu
> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-18 Thread Benjamin Mahler
> On July 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/ --- (Updated 七月 18, 2016, 2:24 p.m.) Review request for mesos, Benjamin Mahler and

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-18 Thread Guangya Liu
> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-18 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/ --- (Updated 七月 18, 2016, 10:13 a.m.) Review request for mesos, Benjamin Mahler

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-17 Thread Guangya Liu
> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-17 Thread Guangya Liu
> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-15 Thread Guangya Liu
> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-15 Thread Guangya Liu
> On 七月 14, 2016, 5:56 p.m., Benjamin Mahler wrote: > > include/mesos/resources.hpp, lines 135-147 > > > > > > This suggests a change of semantics to `Resources`. > > > > Currently: `Resources` always

Re: Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-14 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/#review142257 --- include/mesos/resources.hpp (lines 135 - 147)

Review Request 50017: WIP: Validated the resources when parsing it.

2016-07-14 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50017/ --- Review request for mesos, Benjamin Mahler and Klaus Ma. Repository: mesos