Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

2016-07-21 Thread Neil Conway
> On July 21, 2016, 12:08 p.m., Alexander Rukletsov wrote: > > If we are not interested in rescinding, can't we simply say something like > > ``` > > EXPECT_CALL(sched, offerRescinded(, _)) > > .WillRepeatedly(Return()); > > ``` We could -- I felt like there was value in being a bit more

Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

2016-07-21 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/#review143077 --- If we are not interested in rescinding, can't we simply say

Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

2016-07-19 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/#review142746 --- Patch looks great! Reviews applied: [50186] Passed command:

Re: Review Request 50186: Avoid a GMock warning in a reservation test case.

2016-07-19 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50186/ --- (Updated July 19, 2016, 9:55 a.m.) Review request for mesos and Alexander