Re: Review Request 50810: Fixed provisioner appc support on windows build.

2016-08-09 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review145251 --- Ship it! Note: The original code compiles on Windows :) -

Re: Review Request 50810: Fixed provisioner appc support on windows build.

2016-08-09 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/ --- (Updated Aug. 9, 2016, 12:24 p.m.) Review request for mesos, Artem

Re: Review Request 50810: Fixed provisioner appc support on windows build.

2016-08-09 Thread Gilbert Song
> On Aug. 9, 2016, 10:06 a.m., Jie Yu wrote: > > Second thought. we should just to the following in `__provision`: > > ``` > > #ifdef WINDOWS > > return ProvisionInfo{...}; > > #else > > // the original logic. > > #endif > > ``` Agree. Obviously more clear in this way. Will fix it. - Gilbert

Re: Review Request 50810: Fixed provisioner appc support on windows build.

2016-08-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review145223 --- Second thought. we should just to the following in `__provision`:

Re: Review Request 50810: Fixed provisioner appc support on windows build.

2016-08-09 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review145221 --- Ship it! Ship It! - Jie Yu On Aug. 4, 2016, 5:05 p.m.,

Re: Review Request 50810: Fixed provisioner appc support on windows build.

2016-08-04 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/#review144819 --- Patch looks great! Reviews applied: [50810] Passed command:

Review Request 50810: Fixed provisioner appc support on windows build.

2016-08-04 Thread Gilbert Song
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50810/ --- Review request for mesos, Artem Harutyunyan, Alex Clemmer, Jie Yu, and Joseph