Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

> On 八月 23, 2016, 11:48 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 93 > > > > > > I'd prefer that we move this under `using std::xxx`. > > > > ``` > > using std::list; > > using

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

> On Aug. 23, 2016, 11:48 a.m., Guangya Liu wrote: > > src/master/master.cpp, line 4056 > > > > > > how about s/int/size_t? Yes for most containers or loop iterators, but protobuf uses `int` for `.size()` so I

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

> On Aug. 24, 2016, 12:38 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 3257 > > > > > > do you want to add a "messages_launch_task_groups" metric? My understanding is that `messages_launch_tasks`

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51320/#review146611 --- include/mesos/mesos.proto (lines 1539 - 1542)

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51320/#review146585 --- Fix it, then Ship it! src/master/master.cpp (line 3257)

Re: Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51320/#review146501 --- src/master/master.cpp (line 93)

Review Request 51320: Implemented the LaunchGroup Offer::Operation in the master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51320/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6045