Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/#review149935 --- Ship it! Ship It! - Jie Yu On Sept. 21, 2016, 8:18 p.m.,

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/#review149934 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

> On Sept. 21, 2016, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1647-1652 > > > > > > What if the top level container join non-host network but its child > >

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- (Updated Sept. 21, 2016, 8:18 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

> On Sept. 21, 2016, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 615 > > > > > > We need to return failure if parent does not exist. > > Avinash sridharan wrote:

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

> On Sept. 21, 2016, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, line 378 > > > > > > Should we skip nested container recover here? It's better to be > > explicit.

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

> On Sept. 21, 2016, 12:54 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 1647-1652 > > > > > > What if the top level container join non-host network but its child > >

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/#review149767 --- src/slave/containerizer/mesos/isolators/network/cni/cni.cpp

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

> On Sept. 20, 2016, 9:10 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp, lines 725-733 > > > > > > This is problematic. > > > > If both rootDir and pluginDir is not

Re: Review Request 51857: Modified the `network/cni` isolator to be nesting aware.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51857/ --- (Updated Sept. 21, 2016, 12:06 a.m.) Review request for mesos, Gilbert Song,