Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-20 Thread Anindya Sinha
> On Sept. 20, 2016, 9:34 p.m., Jiang Yan Xu wrote: > > Given these comments, do you want to punt on improving the simple string > > parsing and get the JSON format working first? > > > > Also we should have independent unit tests here in resources_tests.cpp, > > this shouldn't to be coupled

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-20 Thread Anindya Sinha
> On Sept. 20, 2016, 5:49 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 613 > > > > > > Not yours, but I prefer that we quota token as > > > > ``` > > "Bad value for resources, missing or

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149611 --- src/common/resources.cpp (line 613)

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-19 Thread haosdent huang
> On Sept. 19, 2016, 4:55 p.m., haosdent huang wrote: > > src/common/resources.cpp, lines 616-648 > > > > > > This is conflict with range resources `ports:[21000-24000,3-34000]`. > > Anindya Sinha wrote: >

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-19 Thread Anindya Sinha
> On Sept. 19, 2016, 4:55 p.m., haosdent huang wrote: > > src/common/resources.cpp, lines 616-648 > > > > > > This is conflict with range resources `ports:[21000-24000,3-34000]`. I do not think so.

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-19 Thread Anindya Sinha
> On Sept. 19, 2016, 6:40 a.m., Guangya Liu wrote: > > src/common/resources.cpp, line 611 > > > > > > A unit test is needed to test the case when token size is 3 Tests for various cases of token sizes (2 and 3) are

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-19 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/ --- (Updated Sept. 19, 2016, 10:43 p.m.) Review request for mesos and Jiang Yan

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-19 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149490 --- src/common/resources.cpp (lines 616 - 648)

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/#review149433 --- Ditto for v1 src/common/resources.cpp (line 610)

Re: Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/ --- (Updated Sept. 19, 2016, 5:01 a.m.) Review request for mesos and Jiang Yan Xu.

Review Request 52001: Allow text based disk resources to indicate source type and root.

2016-09-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52001/ --- Review request for mesos. Repository: mesos Description --- Text based