Re: Review Request 52295: Added additional unit tests for shared resources.

2016-12-01 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review157627 --- Ship it! Will commit after I run it.

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-18 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review156368 --- Patch looks great! Reviews applied: [52295] Passed command:

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/ --- (Updated Nov. 18, 2016, 7:49 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-18 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/ --- (Updated Nov. 18, 2016, 7:48 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-18 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review156275 --- Fix it, then Ship it!

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-11 Thread Anindya Sinha
> On Nov. 10, 2016, 5:15 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, line 2158 > > > > > > This test is basically identitcal to > > 'AllocateSharedResourcesMultiFrameworks', can we

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-11 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/ --- (Updated Nov. 11, 2016, 6:56 p.m.) Review request for mesos and Jiang Yan Xu.

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-11-10 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review152420 --- src/tests/hierarchical_allocator_tests.cpp (lines 1512 - 1513)

Re: Review Request 52295: Added additional unit tests for shared resources.

2016-09-27 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/#review150528 --- Patch looks great! Reviews applied: [52295] Passed command:

Review Request 52295: Added additional unit tests for shared resources.

2016-09-26 Thread Anindya Sinha
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52295/ --- Review request for mesos and Jiang Yan Xu. Bugs: MESOS-6185