Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-28 Thread Jie Yu
> On Oct. 27, 2016, 5:03 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, lines 71-72 > > > > > > I think James made a valid point there that errno might not be > > preserved across delete.

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-28 Thread James Peach
> On Oct. 27, 2016, 5:03 p.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, lines 71-72 > > > > > > I think James made a valid point there that errno might not be > > preserved across delete.

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-28 Thread Qian Zhang
> On Oct. 28, 2016, 1:03 a.m., Jie Yu wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, lines 71-72 > > > > > > I think James made a valid point there that errno might not be > > preserved across delete.

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-27 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review154042 --- Fix it, then Ship it!

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-24 Thread James Peach
> On Oct. 21, 2016, 4:19 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 26 > > > > > > FreeBSD would need a third branch for the > >

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-24 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/ --- (Updated Oct. 25, 2016, 11:41 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-23 Thread James Peach
> On Oct. 20, 2016, 4:03 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 24 > > > > > > Since the flags differ between platform, it might be a good idea to > > define

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-22 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/ --- (Updated Oct. 23, 2016, 11:01 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-22 Thread Qian Zhang
> On Oct. 20, 2016, 12:03 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 24 > > > > > > Since the flags differ between platform, it might be a good idea to > > define

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-22 Thread Qian Zhang
> On Oct. 22, 2016, 12:19 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 26 > > > > > > FreeBSD would need a third branch for the > >

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-21 Thread James Peach
> On Oct. 20, 2016, 4:03 a.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 64 > > > > > > You could use ``std::vector`` here to avoid manual memory > > management. > > Qian Zhang

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-21 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153556 --- 3rdparty/stout/include/stout/os/posix/xattr.hpp (line 26)

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-21 Thread James Peach
- James --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153347 --- On Oct. 21, 2016, 9:29 a.m., Qian Zhang wrote: > >

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-21 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/ --- (Updated Oct. 21, 2016, 5:29 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-20 Thread Qian Zhang
> On Oct. 20, 2016, 12:03 p.m., James Peach wrote: > > 3rdparty/stout/include/stout/os/posix/xattr.hpp, line 24 > > > > > > Since the flags differ between platform, it might be a good idea to > > define

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-20 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153393 --- 3rdparty/stout/include/stout/os/posix/xattr.hpp (line 24)

Re: Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-19 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/#review153347 --- 3rdparty/stout/include/stout/os/posix/xattr.hpp (line 24)

Review Request 53041: Added `setxattr()` and `getxattr()` in stout.

2016-10-19 Thread Qian Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53041/ --- Review request for mesos. Bugs: MESOS-6360