Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/ --- (Updated Oct. 24, 2016, 8:22 a.m.) Review request for mesos, Anand Mazumdar,

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153676 --- Fix it, then Ship it! Ship It!

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/ --- (Updated Oct. 22, 2016, 5:46 p.m.) Review request for mesos, haosdent huang,

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

> On Oct. 22, 2016, 1:42 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 133 > > > > > > Does all the other tests pass with this change? If I remember correctly > > in the tests we don't

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

> On Oct. 22, 2016, 1:42 p.m., Timothy Chen wrote: > > src/slave/containerizer/docker.cpp, line 133 > > > > > > Does all the other tests pass with this change? If I remember correctly > > in the tests we don't

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153645 --- src/slave/containerizer/docker.cpp (line 131)

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153641 --- Fix it, then Ship it!

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153541 --- Patch looks great! Reviews applied: [53047] Passed command:

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

> On Oct. 21, 2016, 8:58 a.m., haosdent huang wrote: > > src/slave/containerizer/docker.cpp, line 62 > > > > > > Nit: We sort the headers according some rules which `stout` come first. > > Please move this after >

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/ --- (Updated Oct. 21, 2016, 9:34 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153513 --- The patch looks pretty good. For the test case part, it should be

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

> On Oct. 20, 2016, 9:55 a.m., haosdent huang wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 1501 > > > > > > This test case would not go through `parse()` method. Since we only use > >

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/ --- (Updated Oct. 21, 2016, 8:24 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153402 --- Patch looks great! Reviews applied: [53047] Passed command:

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

> On Oct. 20, 2016, 9:55 a.m., haosdent huang wrote: > > src/tests/containerizer/docker_containerizer_tests.cpp, line 1501 > > > > > > This test case would not go through `parse()` method. Since we only use > >

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

> On Oct. 20, 2016, 8:58 a.m., haosdent huang wrote: > > src/slave/containerizer/docker.cpp, lines 124-130 > > > > > > I think need to put this in an `else` block, otherwise it would be > > perform although we get

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/ --- (Updated Oct. 20, 2016, 11:46 a.m.) Review request for mesos, haosdent huang,

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153374 --- src/tests/containerizer/docker_containerizer_tests.cpp (line

Re: Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/#review153361 --- src/slave/containerizer/docker.cpp (lines 124 - 129)

Review Request 53047: MESOS-6212: name format validation for mesos managed docker containers

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53047/ --- Review request for mesos, haosdent huang, Timothy Chen, and Vinod Kone. Bugs: