Re: Review Request 53061: Added abstractions for working with POSIX resource limits.

2016-10-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53061/#review153634 --- src/v1/parse.hpp (line 47)

Re: Review Request 53061: Added abstractions for working with POSIX resource limits.

2016-10-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53061/#review153628 --- Fix it, then Ship it! src/CMakeLists.txt (line 439)

Re: Review Request 53061: Added abstractions for working with POSIX resource limits.

2016-10-20 Thread Benjamin Bannier
> On Oct. 20, 2016, 9:09 p.m., Jie Yu wrote: > > src/posix/rlimit.hpp, line 25 > > > > > > Windows does not use autotool. So you don't have to do this. We just > > need to make sure all callsites are wrapped with ifn

Re: Review Request 53061: Added abstractions for working with POSIX resource limits.

2016-10-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53061/ --- (Updated Oct. 21, 2016, 12:38 a.m.) Review request for mesos and Jie Yu. Chan

Re: Review Request 53061: Added abstractions for working with POSIX resource limits.

2016-10-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53061/ --- (Updated Oct. 20, 2016, 7:01 p.m.) Review request for mesos and Jie Yu. Summa