Re: Review Request 53062: Add rlimit support to Mesos containerizer.

2016-10-21 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53062/#review153635 --- Fix it, then Ship it!

Re: Review Request 53062: Add rlimit support to Mesos containerizer.

2016-10-21 Thread Jie Yu
> On Oct. 20, 2016, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, line 105 > > > > > > That makes me think if we should make 'unlimited' be more explicit. > > With the current scheme,

Re: Review Request 53062: Add rlimit support to Mesos containerizer.

2016-10-21 Thread Jie Yu
> On Oct. 20, 2016, 7:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, lines 592-603 > > > > > > This won't work because data services explicitly want to get limit > > above what's configured. >

Re: Review Request 53062: Add rlimit support to Mesos containerizer.

2016-10-20 Thread Benjamin Bannier
> On Oct. 20, 2016, 9:24 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/launch.cpp, lines 592-603 > > > > > > This won't work because data services explicitly want to get limit > > above what's configured.

Re: Review Request 53062: Add rlimit support to Mesos containerizer.

2016-10-20 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53062/ --- (Updated Oct. 21, 2016, 12:38 a.m.) Review request for mesos and Jie Yu.