Re: Review Request 53645: Added '--task' into mesos-execute.

> On Nov. 19, 2016, 5:23 p.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you rebase the review? > > Vinod Kone wrote: > Do you have perms to commit these reviews yourself? If yes, do you want > to give it a shot? > > This is my typical commit workflow: >

Re: Review Request 53645: Added '--task' into mesos-execute.

> On Nov. 19, 2016, 9:23 a.m., Vinod Kone wrote: > > Ship It! > > Vinod Kone wrote: > Can you rebase the review? Do you have perms to commit these reviews yourself? If yes, do you want to give it a shot? This is my typical commit workflow: $ git checkout master $ git pull origin $ ./supp

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review156441 --- Patch looks great! Reviews applied: [53644, 53645] Passed comman

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/ --- (Updated Nov. 21, 2016, 11:17 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 53645: Added '--task' into mesos-execute.

> On Nov. 19, 2016, 9:23 a.m., Vinod Kone wrote: > > Ship It! Can you rebase the review? - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review156389 --

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review156389 --- Ship it! Ship It! - Vinod Kone On Nov. 11, 2016, 3:13 a.m.,

Re: Review Request 53645: Added '--task' into mesos-execute.

> On Nov. 14, 2016, 4:26 p.m., Abhishek Dasgupta wrote: > > src/cli/execute.cpp, line 342 > > > > > > Should we still continue with our old approach of creating task in > > mesos execute?? You can still continue wi

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review155798 --- src/cli/execute.cpp (line 342)

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review155710 --- Ship it! Ship It! - Avinash sridharan On Nov. 11, 2016, 3:13

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review155701 --- Patch looks great! Reviews applied: [53644, 53645] Passed comman

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/ --- (Updated Nov. 11, 2016, 11:13 a.m.) Review request for mesos, Avinash sridharan

Re: Review Request 53645: Added '--task' into mesos-execute.

> On Nov. 11, 2016, 12:01 a.m., Avinash sridharan wrote: > > src/cli/execute.cpp, line 1065 > > > > > > Instead of this why can't we just do: > > > > Option taskInfo = flags.task > > > > if (flags.

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review155602 --- Patch looks great! Reviews applied: [53644, 53645] Passed comman

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/#review155598 --- src/cli/execute.cpp (line 874)

Re: Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/ --- (Updated Nov. 10, 2016, 9:44 p.m.) Review request for mesos, Avinash sridharan,

Review Request 53645: Added '--task' into mesos-execute.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53645/ --- Review request for mesos, Avinash sridharan and Jie Yu. Repository: mesos Des