Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/#review157102 --- Ship it! Ship It! - Alex Clemmer On Nov. 15, 2016, 10:56

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

> On Nov. 17, 2016, 5:19 p.m., Alex Clemmer wrote: > > src/slave/container_loggers/CMakeLists.txt, line 30 > > > > > > Seems like it might be easier to just `if` out the line that includes > > this `CMakeLists.txt`?

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

> On Nov. 17, 2016, 9:19 a.m., Alex Clemmer wrote: > > src/slave/container_loggers/CMakeLists.txt, line 25 > > > > > > For my own education, this must be shared, rather than > > `MESOS_DEFAULT_LIBRARY_LINKAGE`? Or

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/#review156217 --- src/slave/container_loggers/CMakeLists.txt (line 25)

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/ --- (Updated Nov. 15, 2016, 2:56 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 53756: CMake: Added logrotate container logger module to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/ --- (Updated Nov. 14, 2016, 7:08 p.m.) Review request for mesos, Alex Clemmer and

Review Request 53756: CMake: Added logrotate container logger module to the build.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53756/ --- Review request for mesos, Alex Clemmer and Joris Van Remoortere. Repository: