Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review158010 --- Ship it! Ship It! - Anand Mazumdar On Nov. 23, 2016, 5:46

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 23, 2016, 5:46 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 23, 2016, 4:31 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156446 --- Patch looks great! Reviews applied: [53825] Passed command:

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 21, 2016, 4:46 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > Nice first patch and welcome to the community! > > > > - Can you update the Testing Done section with details on testing? > > - We also support Python bindings. Do you mind adding these protos to our > > python build too in a follow up

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 21, 2016, 4:35 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

> On Nov. 20, 2016, 9:04 p.m., Anand Mazumdar wrote: > > include/mesos/v1/allocator/allocator.proto, lines 21-22 > > > > > > These changes seem unrelated to this change i.e., java protos > > generation. We prefer

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156423 --- Nice first patch and welcome to the community! - Can you update

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156333 --- Anand Mazumdar - Could you please take a look at the patch? -

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156291 --- Patch looks great! Reviews applied: [53825] Passed command:

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 18, 2016, 8:04 a.m.) Review request for mesos, Anand Mazumdar

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/#review156140 --- Ship it! I'm not a mesos committer but this LGTM. - Zameer

Re: Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- (Updated Nov. 16, 2016, 11:02 p.m.) Review request for mesos and Anand

Review Request 53825: MESOS-6597 Enabled java protos generation for all V1 proto files.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53825/ --- Review request for mesos and Anand Mazumdar. Bugs: MESOS-6597