Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review158460 --- Ship it! src/tests/fault_tolerance_tests.cpp (line 2245)

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 7, 2016, 7:11 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 7, 2016, 5:50 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

> On Dec. 3, 2016, 2:12 a.m., Vinod Kone wrote: > > src/master/master.cpp, lines 7132-7137 > > > > > > hmm. it's a bit weird that activating a framework also updates it. this > > should be done by the callers

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 7, 2016, 4:14 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

> On Dec. 3, 2016, 2:12 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 7124 > > > > > > CHECK_NOTNULL(framework); > > Neil Conway wrote: > Is there a general rule for when to add `CHECK_NOTNULL` for

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

> On Dec. 3, 2016, 2:12 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 5602 > > > > > > shouldn't we send a ShutdownFrameworkMessage in this case? This is implemented in a later review in this chain,

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 4, 2016, 2:06 a.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

> On Dec. 3, 2016, 2:12 a.m., Vinod Kone wrote: > > src/master/master.cpp, line 2478 > > > > > > Can you add a comment on when we are here. It is not very obvious. > > Maybe copy paste the comment from #2708? I

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review157867 --- src/master/master.hpp (line 672)

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 2, 2016, 8:56 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Dec. 2, 2016, 5:18 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Nov. 29, 2016, 5:55 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review156518 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Nov. 21, 2016, 9:27 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review156471 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- (Updated Nov. 21, 2016, 4:21 p.m.) Review request for mesos and Vinod Kone.

Re: Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/#review156353 --- Patch looks great! Reviews applied: [53885, 53886, 53887, 53888,

Review Request 53897: Changed how master represents "recovered" frameworks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53897/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-6419