Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On Dec. 2, 2016, 6:36 a.m., Benjamin Mahler wrote: > > src/master/validation.cpp, lines 245-290 > > > > > > We could pull out a `multiRole` boolean here and perform validation > > based on it, this might make the

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review157712 --- src/master/master.cpp (line 2373)

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On 十二月 1, 2016, 10:36 p.m., Benjamin Mahler wrote: > > src/master/master.cpp, lines 2336-2349 > > > > > > It seems problematic here that `frameworkInfo.role()` is accesssed when > > the framework is MULTI_ROLE

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review157651 --- Thanks Jay, looks pretty good! Could you split this patch into

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- (Updated Nov. 30, 2016, 9:57 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review157203 --- src/master/master.cpp (lines 7013 - 7021)

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- (Updated Nov. 27, 2016, 4:12 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156963 --- src/master/validation.cpp (line 258)

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On Nov. 25, 2016, 3:04 p.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 295-305 > > > > > > How about the following? > > > > ``` > > // TODO(jay_guo) Consider extending this method to

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- (Updated Nov. 25, 2016, 3:40 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156920 --- src/master/validation.hpp (lines 60 - 61)

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- (Updated Nov. 25, 2016, 11:26 a.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156890 --- src/master/master.cpp (line 2336)

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On 十一月 25, 2016, 3:20 a.m., Guangya Liu wrote: > > src/common/roles.cpp, lines 110-130 > > > > > > Can we simplify the logic as your diagram above: > > > > ``` > > if (frameworkInfo.roles_size() > 0

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On Nov. 25, 2016, 5:24 a.m., Qian Zhang wrote: > > src/common/roles.cpp, lines 141-143 > > > > > > Can you check the duplicate entries by referring the code below? That > > seems a more clear way to me. > >

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On Nov. 25, 2016, 5:17 a.m., Qian Zhang wrote: > > src/common/roles.cpp, lines 112-118 > > > > > > What if the `MULTI_ROLE` capability is provided, but > > `frameworkInfo.roles` is empty? So in this case

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

> On Nov. 25, 2016, 3:20 a.m., Guangya Liu wrote: > > src/common/roles.cpp, lines 110-130 > > > > > > Can we simplify the logic as your diagram above: > > > > ``` > > if (frameworkInfo.roles_size() > 0

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156881 --- src/common/roles.cpp (lines 141 - 143)

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156877 --- src/common/roles.cpp (lines 112 - 118)

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156878 --- include/mesos/roles.hpp (line 87)

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/#review156853 --- Patch looks great! Reviews applied: [54061, 54062] Passed

Re: Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- (Updated Nov. 24, 2016, 3:30 p.m.) Review request for mesos and Guangya Liu.

Review Request 54062: Added logic to validate FrameworkInfo roles.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54062/ --- Review request for mesos and Guangya Liu. Bugs: MESOS-6629