Re: Review Request 54293: Supported TTY in I/O switchboard.

2016-12-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/ --- (Updated Dec. 5, 2016, 5:37 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54293: Supported TTY in I/O switchboard.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/#review157959 --- Ship it! Ship It! - Kevin Klues On Dec. 4, 2016, 9:21 p.m.,

Re: Review Request 54293: Supported TTY in I/O switchboard.

2016-12-04 Thread Jie Yu
> On Dec. 5, 2016, 2:02 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 248 > > > > > > Can you add a comment here about the difference between the two > > hashsets? Reading top

Re: Review Request 54293: Supported TTY in I/O switchboard.

2016-12-04 Thread Kevin Klues
> On Dec. 5, 2016, 2:02 a.m., Kevin Klues wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 248 > > > > > > Can you add a comment here about the difference between the two > > hashsets? Reading top

Re: Review Request 54293: Supported TTY in I/O switchboard.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/#review157937 --- src/slave/containerizer/mesos/io/switchboard.hpp (line 126)

Re: Review Request 54293: Supported TTY in I/O switchboard.

2016-12-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/ --- (Updated Dec. 4, 2016, 9:21 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 54293: Supported TTY in I/O switchboard.

2016-12-02 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/ --- (Updated Dec. 2, 2016, 6:29 p.m.) Review request for mesos, Benjamin Hindman

Review Request 54293: Supported TTY in I/O switchboard.

2016-12-01 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54293/ --- Review request for mesos, Benjamin Hindman and Kevin Klues. Repository: mesos