Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 16, 2016, 12:08 a.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review159388 --- Fix it, then Ship it! I can fix the spacing before committing.

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 15, 2016, 11:44 p.m.) Review request for mesos, Alex Clemmer and

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 9, 2016, 7:26 a.m.) Review request for mesos, Alex Clemmer and Jo

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158623 --- 3rdparty/stout/include/stout/windows/os.hpp (line 753)

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 8, 2016, 8:15 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 8, 2016, 8:07 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 8, 2016, 8:02 p.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54335: Add `os::var()` to Stout.

> On Dec. 8, 2016, 6:14 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 20 > > > > > > Tiny nit: while you're messing around with the headers, could we > > alphabetize them? No prob

Re: Review Request 54335: Add `os::var()` to Stout.

> On Dec. 8, 2016, 6:14 a.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 772 > > > > > > I think it's worth mentioning specifically something like "will not > > cause us to return di

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158503 --- Ship it! Oops, sorry, meant to mark this as "Fix it, then ship

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158500 --- 3rdparty/stout/include/stout/windows/os.hpp (line 20)

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 8, 2016, 1:49 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54335: Add `os::var()` to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 8, 2016, 12:39 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54335: Add os::var() to Stout.

> On Dec. 5, 2016, 7:30 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/windows/os.hpp, line 782 > > > > > > I think it's worth considering whether this should be canonized and > > encoded as its own func

Re: Review Request 54335: Add os::var() to Stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- (Updated Dec. 8, 2016, 12:21 a.m.) Review request for mesos and Alex Clemmer.

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use `os::runstatedir`

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use `os::runstatedir`

Re: Review Request 54335: Add os::var() to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158122 --- Patch looks great! Reviews applied: [54335] Passed command: expo

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 7:30 p.m., Alex Clemmer wrote: > > 3rdparty/stout/include/stout/posix/os.hpp, line 463 > > > > > > We probably want this function to return `Try`, because we > > want to be able to use `os::var` i

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use `os::runstatedir`

Re: Review Request 54335: Add os::var() to stout.

> On Dec. 5, 2016, 6:31 p.m., Jie Yu wrote: > > Flying by. I am checking > > https://www.gnu.org/prep/standards/html_node/Directory-Variables.html > > > > Looks like, in retrospect, we should call the current `runtime_dir` > > `runstate_dir` instead. So we probably should use `os::runstatedir`

Re: Review Request 54335: Add os::var() to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158032 --- 3rdparty/stout/include/stout/posix/os.hpp (line 463)

Re: Review Request 54335: Add os::var() to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/#review158030 --- Flying by. I am checking https://www.gnu.org/prep/standards/html_

Review Request 54335: Add os::var() to stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54335/ --- Review request for mesos and Alex Clemmer. Bugs: MESOS-6677 https://issues.