Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- (Updated Dec. 5, 2016, 10:05 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- (Updated Dec. 5, 2016, 9:40 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-05 Thread Kevin Klues
> On Dec. 5, 2016, 6:39 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 539 > > > > > > We should not capture 'this' without a defer. Either use a 'defer' > > here, or capture

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/#review158033 --- Fix it, then Ship it!

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- (Updated Dec. 5, 2016, 7:10 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-04 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/#review157961 --- src/slave/containerizer/mesos/io/switchboard.cpp (lines 407 -

Re: Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- (Updated Dec. 5, 2016, 12:39 a.m.) Review request for mesos and Jie Yu.

Review Request 54352: Added removal of unix domain socket path in IOSwitchboard::cleanup.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54352/ --- Review request for mesos and Jie Yu. Bugs: 6689