Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-06 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 6, 2016, 7:46 p.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-06 Thread Kevin Klues
> On Dec. 6, 2016, 5:31 a.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, line 161 > > > > > > or agent crashes right before we create the directory and fork the > > server. Would we actuall

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/#review158121 --- Fix it, then Ship it! src/slave/containerizer/mesos/io/switchb

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 6, 2016, 4:55 a.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/#review158097 --- src/slave/containerizer/mesos/io/switchboard.cpp (lines 147 - 148

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 6, 2016, 12:21 a.m.) Review request for mesos and Jie Yu. Chang

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Jie Yu
> On Dec. 5, 2016, 9:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 537-547 > > > > > > It's likely that the io switchboard server has been forked, but the > > agent crashes befor

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Kevin Klues
> On Dec. 5, 2016, 9:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 537-547 > > > > > > It's likely that the io switchboard server has been forked, but the > > agent crashes befor

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Kevin Klues
> On Dec. 5, 2016, 9:11 p.m., Jie Yu wrote: > > src/slave/containerizer/mesos/io/switchboard.cpp, lines 167-171 > > > > > > I think this flag should apply to containers that are about to be > > launched next. > >

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/#review158038 --- src/slave/containerizer/mesos/io/switchboard.cpp (line 153)

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-05 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 5, 2016, 9:46 a.m.) Review request for mesos and Jie Yu. Change

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 5, 2016, 7:11 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- (Updated Dec. 5, 2016, 7:10 a.m.) Review request for mesos and Jie Yu. Change

Review Request 54355: Added implementation of `recover()` to the IOSwitchboard isolator.

2016-12-04 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54355/ --- Review request for mesos and Jie Yu. Bugs: MESOS-6688 https://issues.apache