Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-02-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/#review165625 --- 3rdparty/stout/include/stout/os/windows/environment.hpp (line

Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-02-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/#review165576 --- Ship it! A few minor nits below that I will fix before

Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-02-14 Thread Alex Clemmer
> On Jan. 24, 2017, 2:23 a.m., Joseph Wu wrote: > > 3rdparty/stout/include/stout/os/raw/environment.hpp, lines 108-120 > > > > > > Should we also move away from functions like `os::execvpe`? If so, we > > would be

Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-02-14 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/ --- (Updated Feb. 14, 2017, 6:47 p.m.) Review request for mesos, Andrew

Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-01-23 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/#review162754 --- I agree with this change, just a few questions/tweaks:

Re: Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/ --- (Updated Jan. 15, 2017, 9:44 p.m.) Review request for mesos, Andrew

Review Request 55547: Windows: Standardize on win32 environment, transition away from CRT.

2017-01-15 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55547/ --- Review request for mesos, Andrew Schwartzmeyer, Daniel Pravat, and Joseph Wu.