Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-02-03 Thread Guangya Liu
> On 一月 28, 2017, 11:45 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1133-1137 > > > > > > Add `role` here in the log message? > > Benjamin Mahler wrote: > Hm.. not sure what

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-02-03 Thread Benjamin Mahler
> On Jan. 28, 2017, 11:45 a.m., Guangya Liu wrote: > > include/mesos/allocator/allocator.hpp, line 91 > > > > > > I think that we also need to reflect this in CHANGELOG to clarify that > > this interface was updated

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-02-03 Thread Benjamin Mahler
> On Jan. 30, 2017, 4:12 p.m., Benjamin Bannier wrote: > > Thanks! > On Jan. 30, 2017, 4:12 p.m., Benjamin Bannier wrote: > > include/mesos/allocator/allocator.hpp, lines 89-92 > > > > > > What is the reason for

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-01-30 Thread Michael Park
> On Jan. 30, 2017, 8:12 a.m., Benjamin Bannier wrote: > > include/mesos/allocator/allocator.hpp, lines 89-92 > > > > > > What is the reason for changing this interface? We should think hard > > before making it too

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-01-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55870/#review163625 --- Fix it, then Ship it! src/master/master.cpp (lines 6541 -

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-01-30 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55870/#review163591 --- Fix it, then Ship it!

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-01-30 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55870/#review163516 --- include/mesos/allocator/allocator.hpp (lines 89 - 92)

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-01-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55870/#review163404 --- src/master/allocator/mesos/hierarchical.cpp (lines 820 - 824)

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-01-28 Thread Guangya Liu
> On 一月 28, 2017, 11:45 a.m., Guangya Liu wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1176-1177 > > > > > > A question here: Why not call `resources.unallocate()` at #1130? > > > > This

Re: Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-01-28 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55870/#review163388 --- include/mesos/allocator/allocator.hpp (line 91)

Review Request 55870: Update the allocator to handle frameworks with multiple roles.

2017-01-25 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55870/ --- Review request for mesos, Benjamin Bannier, Jay Guo, Guangya Liu, and Michael