Re: Review Request 55900: Improved style in `HealthChecker`.

2017-02-05 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review164311 --- Ship it! Ship It! - haosdent huang On Feb. 2, 2017, 4:54

Re: Review Request 55900: Improved style in `HealthChecker`.

2017-02-02 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/ --- (Updated Feb. 2, 2017, 4:54 p.m.) Review request for mesos, Alexander

Re: Review Request 55900: Improved style in `HealthChecker`.

2017-01-27 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review163348 --- Ship it! Ship It! - Vinod Kone On Jan. 25, 2017, 6:15 p.m.,

Re: Review Request 55900: Improved style in `HealthChecker`.

2017-01-27 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review163250 --- Ship it! Ship It! - Alexander Rukletsov On Jan. 25, 2017,

Re: Review Request 55900: Improved style in `HealthChecker`.

2017-01-27 Thread Alexander Rukletsov
> On Jan. 25, 2017, 6:09 p.m., haosdent huang wrote: > > I remember we have special reason to use `Option` here instead of `const > > Option&` in previous patches. @alex may remember that, or I > > missunderstanding something here? > > Gastón Kleiman wrote: > The parameter was introduced

Re: Review Request 55900: Improved style in `HealthChecker`.

2017-01-25 Thread Gastón Kleiman
> On Jan. 25, 2017, 6:09 p.m., haosdent huang wrote: > > I remember we have special reason to use `Option` here instead of `const > > Option&` in previous patches. @alex may remember that, or I > > missunderstanding something here? The parameter was introduced here:

Re: Review Request 55900: Improved style in `HealthChecker`.

2017-01-25 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/ --- (Updated Jan. 25, 2017, 6:15 p.m.) Review request for mesos, Alexander

Re: Review Request 55900: Improved style in `HealthChecker`.

2017-01-25 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/#review162982 --- I remember we have special reason to use `Option` here instead of

Review Request 55900: Improved style in `HealthChecker`.

2017-01-24 Thread Gastón Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55900/ --- Review request for mesos, Alexander Rukletsov, Anand Mazumdar, haosdent huang,