Re: Review Request 56314: Fix the OS X build.

2017-02-04 Thread Jiang Yan Xu
> On Feb. 4, 2017, 8:48 p.m., Guangya Liu wrote: > > Seems the docker_archive.hpp also need some update. The places that actually use DockerArchive and Rootfs are still linux only. Agreed that this (not just `Rootfs` but linux only headers in general) is pretty error-prone though and we

Re: Review Request 56314: Fix the OS X build.

2017-02-04 Thread Jiang Yan Xu
> On Feb. 4, 2017, 11:25 p.m., Jiang Yan Xu wrote: > > Ship It! Gotta call it macOS man. :) - Jiang Yan --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/#review164271

Re: Review Request 56314: Fix the OS X build.

2017-02-04 Thread Jiang Yan Xu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/#review164271 --- Ship it! Ship It! - Jiang Yan Xu On Feb. 4, 2017, 7:47

Re: Review Request 56314: Fix the OS X build.

2017-02-04 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/#review164266 --- Seems the docker_archive.hpp also need some update. - Guangya

Review Request 56314: Fix the OS X build.

2017-02-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/ --- Review request for mesos, Benjamin Bannier and Jiang Yan Xu. Repository: mesos

Re: Review Request 56314: Fix the OS X build.

2017-02-04 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56314/ --- (Updated Feb. 5, 2017, 3:47 a.m.) Review request for mesos, Benjamin Bannier