Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.

2017-02-14 Thread Alex Clemmer
> On Feb. 14, 2017, 11:05 p.m., Joseph Wu wrote: > > When we switched `mkdtemp` (directory version), that exposed some odd > > behavior on OSX due to how lengthy OSX's default temporary directory is. > > The IO Switchboard tests there ran into a 108 character limit for Unix > > sockets. It

Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.

2017-02-14 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/#review165582 --- Ship it! When we switched `mkdtemp` (directory version), that

Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.

2017-02-09 Thread Andrew Schwartzmeyer
> On Feb. 9, 2017, 6:55 p.m., Andrew Schwartzmeyer wrote: > > Ship It! (But it might have some repercussions. It looks like the default use of `mktemp()` is now changing from `/tmp` (correct on Linux, incorrect on Windows), to `.` (current folder, working anywhere, but "correct" nowhere). -

Re: Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.

2017-02-09 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/#review164968 --- Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 9, 2017,

Review Request 56504: Stout: Made `os::mktemp` fully cross-platform.

2017-02-09 Thread Alex Clemmer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56504/ --- Review request for mesos, Andrew Schwartzmeyer and Joseph Wu. Repository: