Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

2017-04-11 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/ --- (Updated April 11, 2017, 9:58 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

2017-04-11 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/#review171538 --- Ship it! Ship It! - Adam B On March 22, 2017, 11:36 a.m., Ne

Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

2017-03-29 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/#review170501 --- Ship it! Ship It! - Michael Park On March 22, 2017, 11:36 a.

Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

2017-03-23 Thread Alexander Rukletsov
> On March 20, 2017, 6:26 p.m., Benjamin Mahler wrote: > > Hm.. seems like there was no test for this "optimization" if the tests > > pass, did you do a scan of the allocator unit tests to be sure we're not > > leaving a stale test lying around? > > Neil Conway wrote: > The change was intr

Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

2017-03-22 Thread Neil Conway
> On March 20, 2017, 6:26 p.m., Benjamin Mahler wrote: > > Hm.. seems like there was no test for this "optimization" if the tests > > pass, did you do a scan of the allocator unit tests to be sure we're not > > leaving a stale test lying around? > > Neil Conway wrote: > The change was intr

Re: Review Request 57788: Changed allocator to skip allocation on weight and quota changes.

2017-03-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57788/ --- (Updated March 22, 2017, 6:36 p.m.) Review request for mesos, Adam B, Benjamin