Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On June 1, 2017, 5:41 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 449-450 (original), 479-481 (patched) > > > > > > Not your bug, but it seems wrong to be activating

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated June 5, 2017, 10 p.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review176940 --- Ship it! Ship It! - Vinod Kone On June 2, 2017, 9:29 p.m.,

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

- Anindya --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review176833 --- On June 2, 2017, 9:29 p.m., Anindya Sinha wrote: > >

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On June 2, 2017, 7:51 p.m., Vinod Kone wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 463 (patched) > > > > > > what about new roles that are also suppressed? > > Anindya Sinha wrote: >

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On June 1, 2017, 5:41 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 449-450 (original), 479-481 (patched) > > > > > > Not your bug, but it seems wrong to be activating

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On June 2, 2017, 7:51 p.m., Vinod Kone wrote: > > src/master/allocator/mesos/hierarchical.cpp > > Lines 430-431 (patched) > > > > > > what about roles that are suppressed in old state and new state? If a

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review176833 --- src/master/allocator/mesos/hierarchical.cpp Lines 430-431

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On June 1, 2017, 5:41 p.m., Benjamin Mahler wrote: > > src/common/protobuf_utils.hpp > > Lines 359-361 (patched) > > > > > > This looks to be just a generic conversion from repeated ptr field to > > set, not

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated June 2, 2017, 5:49 p.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review176630 --- src/common/protobuf_utils.hpp Lines 359-361 (patched)

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated June 1, 2017, 12:38 a.m.) Review request for mesos, James Peach,

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated May 31, 2017, 2:52 p.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On May 23, 2017, 9:01 p.m., Vinod Kone wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Line 309 (original), 309 (patched) > > > > > > I don't quite follow why you need to have this variable here?

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated May 31, 2017, 8 a.m.) Review request for mesos, James Peach, Vinod

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review176414 --- Ship it! LGTM. Would be great if one of @bmahler, @mpark or

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On May 23, 2017, 9:01 p.m., Vinod Kone wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Line 309 (original), 309 (patched) > > > > > > I don't quite follow why you need to have this variable here?

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated May 23, 2017, 10:19 p.m.) Review request for mesos, James Peach,

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

> On May 23, 2017, 9:01 p.m., Vinod Kone wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Line 309 (original), 309 (patched) > > > > > > I don't quite follow why you need to have this variable here?

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/#review175846 --- src/master/allocator/mesos/hierarchical.hpp Line 309 (original),

Re: Review Request 57817: Offers not sent for suppressed roles as indicated in `SUBSCRIBE`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57817/ --- (Updated May 19, 2017, 6:26 p.m.) Review request for mesos, James Peach, Vinod