Re: Review Request 58126: Windows: Stout: Reimplemented `stringify_args`.

2017-04-03 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58126/#review170947 --- Ship it! I dislike the fact we need to do this sort of

Re: Review Request 58126: Windows: Stout: Reimplemented `stringify_args`.

2017-03-31 Thread Andrew Schwartzmeyer
> On April 1, 2017, 12:04 a.m., Jeff Coffler wrote: > > 3rdparty/stout/include/stout/os/windows/shell.hpp > > Line 179 (original), 179 (patched) > > > > > > Wow. I'd really like to see unit tests on that, so that we

Re: Review Request 58126: Windows: Stout: Reimplemented `stringify_args`.

2017-03-31 Thread Jeff Coffler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58126/#review170804 --- 3rdparty/stout/include/stout/os/windows/shell.hpp Line 179

Review Request 58126: Windows: Stout: Reimplemented `stringify_args`.

2017-03-31 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58126/ --- Review request for mesos, Jeff Coffler, John Kordich, Joseph Wu, Li Li, and

Re: Review Request 58126: Windows: Stout: Reimplemented `stringify_args`.

2017-03-31 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58126/#review170800 --- 3rdparty/stout/include/stout/os/windows/shell.hpp Lines 186-187