Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

> On May 31, 2017, 8:14 p.m., Andrew Schwartzmeyer wrote: > > Does not build on Windows. Please ensure that the tests include _at least_ > > a compilation on Windows before committing. The build is broken now. I don't think we can expect users to compile on windows, OS X and linux for all of

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review176508 --- Does not build on Windows. Please ensure that the tests include

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review176360 --- Fix it, then Ship it! 3rdparty/libprocess/src/process.cpp

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review174754 --- Currently we require getting the peer each time we receive some

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

> On May 2, 2017, 12:34 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp > > Lines 2878-2879 (patched) > > > > > > We could refer to the flag help for examples? I updated the text a bit. > On

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated May 10, 2017, 6:06 p.m.) Review request for mesos and Benjamin

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review174344 --- 3rdparty/libprocess/src/process.cpp Lines 955 (patched)

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated May 4, 2017, 3:52 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review173903 --- Patch looks great! Reviews applied: [58977, 58928, 58224]

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated May 4, 2017, 12:31 a.m.) Review request for mesos and Benjamin

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

> On May 2, 2017, 12:34 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/src/process.cpp > > Lines 480-492 (patched) > > > > > > I'm wondering if we can eliminate the need for this via global flag > > access

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated May 3, 2017, 10:35 p.m.) Review request for mesos and Benjamin

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review173718 --- Patch looks great! Reviews applied: [58928, 58224] Passed

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated May 2, 2017, 9:02 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated May 2, 2017, 5:59 p.m.) Review request for mesos and Benjamin Mahler.

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review173536 --- Can you pull the test changes out into a separate patch? Overall

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/#review172303 --- Patch looks great! Reviews applied: [58517, 58224] Passed

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated April 18, 2017, 9:11 p.m.) Review request for mesos and Mesos

Re: Review Request 58224: Optionally verify the source IP address for libprocess messages.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58224/ --- (Updated April 18, 2017, 9:02 p.m.) Review request for mesos and Mesos