Re: Review Request 58552: Resolved a TODO of MULTI_ROLE.

2017-06-26 Thread Jay Guo
> On June 26, 2017, 2:55 p.m., Benjamin Mahler wrote: > > src/master/master.hpp > > Line 2838 (original), 2838-2839 (patched) > > > > > > Rather than the comment, we should just call this function > >

Re: Review Request 58552: Resolved a TODO of MULTI_ROLE.

2017-06-26 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58552/#review178864 --- Fix it, then Ship it! src/master/master.hpp Line 2838

Re: Review Request 58552: Resolved a TODO of MULTI_ROLE.

2017-04-19 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58552/#review172449 --- Patch looks great! Reviews applied: [58552] Passed command:

Review Request 58552: Resolved a TODO of MULTI_ROLE.

2017-04-19 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58552/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description