Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-29 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176266 --- This needs rebasing after the changes in 59177 - Kevin Klues

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-25 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176151 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-25 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 25, 2017, 9:08 a.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-24 Thread Kevin Klues
> On May 25, 2017, 3:16 a.m., Kevin Klues wrote: > > src/cli_new/lib/cli/tests/base.py > > Lines 216 (patched) > > > > > > We need to be consistent here. If all functions in this file that we > > pass to

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176035 --- src/cli_new/lib/cli/tests/base.py Lines 216 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-24 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review176034 --- src/cli_new/lib/cli/tests/base.py Lines 281-288 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-24 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175969 --- src/cli_new/lib/cli/tests/base.py Lines 51 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-24 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175927 --- src/cli_new/lib/cli/tests/base.py Lines 356 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-24 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175925 --- src/cli_new/lib/cli/tests/base.py Lines 269 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-24 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 24, 2017, 1:28 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175849 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-23 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175828 --- src/cli_new/lib/cli/tests/base.py Lines 263 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-23 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175826 --- src/cli_new/lib/cli/tests/base.py Lines 265 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-23 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175813 --- src/cli_new/lib/cli/tests/base.py Lines 333 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-23 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175802 --- src/cli_new/lib/cli/tests/base.py Lines 198 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-23 Thread Andrei Budnik
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review175800 --- src/cli_new/lib/cli/tests/base.py Lines 52 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-09 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review174294 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-08 Thread Armand Grillet
> On May 7, 2017, 8:13 p.m., Kevin Klues wrote: > > src/cli_new/lib/cli/constants.py > > Lines 18-25 (patched) > > > > > > Aso is, I think we should bundle this under cli/tests/constants.py. > > > > However,

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-08 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 8, 2017, 5:27 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-07 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review174131 --- src/cli_new/lib/cli/__init__.py Line 18 (original), 18 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-05 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review174111 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-05 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 5, 2017, 5:02 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-04 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review173951 --- Patch looks great! Reviews applied: [58719, 58720] Passed

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-04 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- (Updated May 4, 2017, 1:59 p.m.) Review request for mesos and Kevin Klues.

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-02 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review173669 --- src/cli_new/lib/cli/tests/base.py Lines 116-117 (patched)

Re: Review Request 58720: CLI: Extended the unit test infrastructure.

2017-05-02 Thread Kevin Klues
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/#review173673 --- src/cli_new/lib/cli/tests/base.py Lines 133 (patched)

Review Request 58720: CLI: Extended the unit test infrastructure.

2017-04-25 Thread Armand Grillet
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58720/ --- Review request for mesos and Kevin Klues. Bugs: MESOS-7283