Re: Review Request 59464: Add Fetcher total and success metrics.

2017-05-30 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59464/#review176340 --- It looks like all of your patches are getting marked with

Re: Review Request 59464: Add Fetcher total and success metrics.

2017-05-23 Thread James Peach
> On May 23, 2017, 1:04 a.m., Joseph Wu wrote: > > What do you think about making fetch failures a sub-metric of > > `container_launch_errors`? The fetcher is only called during container > > launch. If fetching fails, container launch will also fail (and increment > > this counter). It

Re: Review Request 59464: Add Fetcher total and success metrics.

2017-05-22 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59464/#review175740 --- What do you think about making fetch failures a sub-metric of