Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-30 Thread Andrew Schwartzmeyer
> On May 26, 2017, 4:52 p.m., Zhitao Li wrote: > > 3rdparty/cmake/Versions.cmake > > Lines 30 (patched) > > > > > > Can you explain how is these hashes geneareted and used? > > > > I'm working on upgrading

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-26 Thread Joseph Wu
> On May 26, 2017, 9:52 a.m., Zhitao Li wrote: > > 3rdparty/cmake/Versions.cmake > > Lines 30 (patched) > > > > > > Can you explain how is these hashes geneareted and used? > > > > I'm working on upgrading

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-26 Thread Zhitao Li
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review176208 --- 3rdparty/cmake/Versions.cmake Lines 30 (patched)

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-25 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review176133 --- Ship it! Ship It! - Joseph Wu On May 24, 2017, 12:13 p.m.,

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-25 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review176117 --- Patch looks great! Reviews applied: [59536] Passed command:

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-24 Thread Aaron Wood via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review175985 --- Ship it! Ship It! - Aaron Wood On May 24, 2017, 7:13 p.m.,

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-24 Thread Andrew Schwartzmeyer
> On May 24, 2017, 7:47 p.m., Aaron Wood wrote: > > Are these hashes checked anywhere? I didn't seen anything that's verifying > > the hashes. Yes, the `URL_HASH` argument to the `ExternalProject_Add` [macro](https://cmake.org/cmake/help/v3.8/module/ExternalProject.html) performs automatic

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-24 Thread Aaron Wood via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/#review175979 --- Are these hashes checked anywhere? I didn't seen anything that's

Re: Review Request 59536: CMake: Added SHA256 hashes for 3rdparty downloads.

2017-05-24 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59536/ --- (Updated May 24, 2017, 7:13 p.m.) Review request for mesos, Aaron Wood and